netdev - Re: [PATCH v2 19/23] net: ethernet: freescale: make UCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8b52b7f-9a96-7f7e-1360-7e4ed723d286@c-s.fr>
Date:   Wed, 30 Oct 2019 11:55:25 +0100
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>,
        Qiang Zhao <qiang.zhao@....com>, Li Yang <leoyang.li@....com>
Cc:     linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Scott Wood <oss@...error.net>,
        Valentin Longchamp <valentin.longchamp@...mile.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 19/23] net: ethernet: freescale: make UCC_GETH
 explicitly depend on PPC32



Le 25/10/2019 à 14:40, Rasmus Villemoes a écrit :
> Currently, QUICC_ENGINE depends on PPC32, so this in itself does not
> change anything. In order to allow removing the PPC32 dependency from
> QUICC_ENGINE and avoid allmodconfig build failures, add this explicit
> dependency.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>   drivers/net/ethernet/freescale/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index 6a7e8993119f..97d27c7740d4 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -75,6 +75,7 @@ config FSL_XGMAC_MDIO
>   config UCC_GETH
>   	tristate "Freescale QE Gigabit Ethernet"
>   	depends on QUICC_ENGINE
> +	depends on PPC32

I think it would be more obvious to have:
	depends on QUICC_ENGINE && PPC32

Christophe

>   	select FSL_PQ_MDIO
>   	select PHYLIB
>   	---help---
>