netdev - Re: [PATCH net-next v5 02/10] net: openvswitch: convert mask list in mask array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191030.141834.1101560184694944976.davem@davemloft.net>
Date:   Wed, 30 Oct 2019 14:18:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiangxia.m.yue@...il.com
Cc:     gvrose8192@...il.com, pshelar@....org, netdev@...r.kernel.org,
        dev@...nvswitch.org
Subject: Re: [PATCH net-next v5 02/10] net: openvswitch: convert mask list
 in mask array

From: xiangxia.m.yue@...il.com
Date: Sat, 19 Oct 2019 16:08:36 +0800

> @@ -611,13 +683,8 @@ struct sw_flow *ovs_flow_tbl_lookup_ufid(struct flow_table *tbl,
>  
>  int ovs_flow_tbl_num_masks(const struct flow_table *table)
>  {
> -	struct sw_flow_mask *mask;
> -	int num = 0;
> -
> -	list_for_each_entry(mask, &table->mask_list, list)
> -		num++;
> -
> -	return num;
> +	struct mask_array *ma = rcu_dereference_ovsl(table->mask_array);
> +	return ma->count;
>  }

Please put an empty line between the variable declarations and the start of the
code in this function.