netdev - Re: [PATCH net-next v5 04/10] net: openvswitch: optimize flow mask cache hash collision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191030.141905.193278198817861701.davem@davemloft.net>
Date:   Wed, 30 Oct 2019 14:19:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiangxia.m.yue@...il.com
Cc:     gvrose8192@...il.com, pshelar@....org, netdev@...r.kernel.org,
        dev@...nvswitch.org
Subject: Re: [PATCH net-next v5 04/10] net: openvswitch: optimize flow mask
 cache hash collision

From: xiangxia.m.yue@...il.com
Date: Sat, 19 Oct 2019 16:08:38 +0800

> @@ -516,18 +519,31 @@ static struct sw_flow *flow_lookup(struct flow_table *tbl,
>  				   u32 *index)
>  {
>  	struct sw_flow *flow;
> +	struct sw_flow_mask *mask;
>  	int i;

Please preserve the reverse christmas tree ordering of local variables here.

Thank you.