netdev - Re: [PATCH net-next v5 06/10] net: openvswitch: simplify the flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191030.141947.1034101510343049475.davem@davemloft.net>
Date:   Wed, 30 Oct 2019 14:19:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiangxia.m.yue@...il.com
Cc:     gvrose8192@...il.com, pshelar@....org, netdev@...r.kernel.org,
        dev@...nvswitch.org
Subject: Re: [PATCH net-next v5 06/10] net: openvswitch: simplify the
 flow_hash

From: xiangxia.m.yue@...il.com
Date: Sat, 19 Oct 2019 16:08:40 +0800

> @@ -432,13 +432,9 @@ int ovs_flow_tbl_flush(struct flow_table *flow_table)
>  static u32 flow_hash(const struct sw_flow_key *key,
>  		     const struct sw_flow_key_range *range)
>  {
> -	int key_start = range->start;
> -	int key_end = range->end;
> -	const u32 *hash_key = (const u32 *)((const u8 *)key + key_start);
> -	int hash_u32s = (key_end - key_start) >> 2;
> -
> +	const u32 *hash_key = (const u32 *)((const u8 *)key + range->start);
>  	/* Make sure number of hash bytes are multiple of u32. */
> -	BUILD_BUG_ON(sizeof(long) % sizeof(u32));
> +	int hash_u32s = range_n_bytes(range) >> 2;

Please place an empty line between the last local variable declaration and
the start of comments and code in the body of the function.

Thank you.