netdev - Re: [PATCH net] gve: Fixes DMA synchronization.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOPXMbm-rtONc+HLvVc8tuo1ftdkfkKX83DK0sFhb53aujrwWg@mail.gmail.com>
Date:   Wed, 30 Oct 2019 14:50:23 -0700
From:   Yangchun Fu <yangchun@...gle.com>
To:     Simon Horman <simon.horman@...ronome.com>
Cc:     netdev@...r.kernel.org, Catherine Sullivan <csully@...gle.com>
Subject: Re: [PATCH net] gve: Fixes DMA synchronization.

On Mon, Oct 28, 2019 at 11:23:09AM -0700, Yangchun Fu wrote:
>> +static inline void gve_dma_sync_for_device(struct gve_priv *priv,
>
> It seems that only priv->pdev->dev is used in this function.  Perhaps it
> would be better to pass it to this function rather than all of priv.

Thanks for the review. I will send v2 patch with the fix.