netdev - Re: [PATCH net] gve: Fixes DMA synchronization.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOPXMbnBtxY4bkXkCJY3hUZjF48V7eoXa6oLmY9EO456kr4svQ@mail.gmail.com>
Date:   Wed, 30 Oct 2019 14:51:14 -0700
From:   Yangchun Fu <yangchun@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Catherine Sullivan <csully@...gle.com>
Subject: Re: [PATCH net] gve: Fixes DMA synchronization.

On Tue, Oct 29, 2019 at 5:41 PM David Miller <davem@...emloft.net> wrote:
>> diff --git a/drivers/net/ethernet/google/gve/gve_tx.c b/drivers/net/ethernet/google/gve/gve_tx.c
>> index 778b87b5a06c..d8342b7b9764 100644
>> --- a/drivers/net/ethernet/google/gve/gve_tx.c
>> +++ b/drivers/net/ethernet/google/gve/gve_tx.c
>> @@ -390,7 +390,23 @@ static void gve_tx_fill_seg_desc(union gve_tx_desc *seg_desc,
>>       seg_desc->seg.seg_addr = cpu_to_be64(addr);
>>  }
>>
>> -static int gve_tx_add_skb(struct gve_tx_ring *tx, struct sk_buff *skb)
>> +static inline void gve_dma_sync_for_device(struct gve_priv *priv,
>> +                                        dma_addr_t *page_buses,
>> +                                        u64 iov_offset, u64 iov_len)
>
> Never use the inline keyword in foo.c files, let the compiler device

Thanks for the review. I will send the v2 patch with the fix.