netdev - Re: [PATCH net-next v3 2/5] bus: fsl-mc: add the fsl_mc_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191030.145917.1263185053715293146.davem@davemloft.net>
Date:   Wed, 30 Oct 2019 14:59:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ioana.ciornei@....com
Cc:     netdev@...r.kernel.org, laurentiu.tudor@....com, andrew@...n.ch,
        f.fainelli@...il.com, linux@...linux.org.uk
Subject: Re: [PATCH net-next v3 2/5] bus: fsl-mc: add the
 fsl_mc_get_endpoint function

From: Ioana Ciornei <ioana.ciornei@....com>
Date: Fri, 25 Oct 2019 13:17:07 +0300

> @@ -712,6 +712,39 @@ void fsl_mc_device_remove(struct fsl_mc_device *mc_dev)
>  }
>  EXPORT_SYMBOL_GPL(fsl_mc_device_remove);
>  
> +struct fsl_mc_device *fsl_mc_get_endpoint(struct fsl_mc_device *mc_dev)
> +{

Like Andrew, I'd really like to see this returning error pointers.

Even if right now the callers don't really change their actions in any
way for different error types.  It's just so much clearer with error
pointers and opens up propagation of error codes in the future if that
works.

Thank you.