netdev - Re: [PATCH net-next v3 2/5] bus: fsl-mc: add the fsl_mc_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB2800C85DDF69B699620DF973E0600@VI1PR0402MB2800.eurprd04.prod.outlook.com>
Date:   Wed, 30 Oct 2019 22:26:39 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v3 2/5] bus: fsl-mc: add the fsl_mc_get_endpoint
 function

On 10/30/19 11:59 PM, David Miller wrote:
> From: Ioana Ciornei <ioana.ciornei@....com>
> Date: Fri, 25 Oct 2019 13:17:07 +0300
> 
>> @@ -712,6 +712,39 @@ void fsl_mc_device_remove(struct fsl_mc_device *mc_dev)
>>   }
>>   EXPORT_SYMBOL_GPL(fsl_mc_device_remove);
>>   
>> +struct fsl_mc_device *fsl_mc_get_endpoint(struct fsl_mc_device *mc_dev)
>> +{
> 
> Like Andrew, I'd really like to see this returning error pointers.
> 
> Even if right now the callers don't really change their actions in any
> way for different error types.  It's just so much clearer with error
> pointers and opens up propagation of error codes in the future if that
> works.
> 
> Thank you.
> 


Sure, no problem. I'll submit a v4 shortly.

Thanks,
Ioana