netdev - Re: [PATCHv3 1/1] net: forcedeth: add xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191029.211407.790828950610293560.davem@davemloft.net>
Date:   Tue, 29 Oct 2019 21:14:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yanjun.zhu@...cle.com
Cc:     jakub.kicinski@...ronome.com, rain.1986.08.12@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCHv3 1/1] net: forcedeth: add xmit_more support

From: Zhu Yanjun <yanjun.zhu@...cle.com>
Date: Wed, 30 Oct 2019 12:18:43 +0800

> If igb does not handle DMA error, it is not appropriate for us to
> handle DMA error.
> 
> After igb fixes this DMA error, I will follow.;-)

Sorry, this is an invalid and unaceptable argument.

Just because a bug exists in another driver, does not mean you
can copy that bug into your driver.

Fix the check, do things properly, and resubmit your patch only after
you've done that.

Thank you.