netdev - Re: [PATCHv3 1/1] net: forcedeth: add xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <434f2be9-0ab5-4a02-d1ff-5cc969addf49@oracle.com>
Date:   Wed, 30 Oct 2019 12:30:40 +0800
From:   Zhu Yanjun <yanjun.zhu@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     jakub.kicinski@...ronome.com, rain.1986.08.12@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCHv3 1/1] net: forcedeth: add xmit_more support


On 2019/10/30 12:14, David Miller wrote:
> From: Zhu Yanjun <yanjun.zhu@...cle.com>
> Date: Wed, 30 Oct 2019 12:18:43 +0800
>
>> If igb does not handle DMA error, it is not appropriate for us to
>> handle DMA error.
>>
>> After igb fixes this DMA error, I will follow.;-)
> Sorry, this is an invalid and unaceptable argument.
>
> Just because a bug exists in another driver, does not mean you
> can copy that bug into your driver.
>
> Fix the check, do things properly, and resubmit your patch only after

OK. I will follow the advice from you and Jakub.

After this DMA error is handled, I will resubmit the commit again.

Thanks,

Zhu Yanjun

> you've done that.
>
> Thank you.
>