lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Oct 2019 04:47:57 -0700 From: Joe Perches <joe@...ches.com> To: madalin.bucur@....com, davem@...emloft.net, netdev@...r.kernel.org Cc: roy.pledge@....com, jakub.kicinski@...ronome.com Subject: Re: [net-next 10/13] dpaa_eth: remove netdev_err() for user errors On Thu, 2019-10-31 at 13:36 +0200, Madalin Bucur wrote: > User reports that an application making an (incorrect) call to > restart AN on a fixed link DPAA interface triggers an error in > the kernel log while the returned EINVAL should be enough. [] > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c [] > @@ -81,7 +81,6 @@ static int dpaa_get_link_ksettings(struct net_device *net_dev, > struct ethtool_link_ksettings *cmd) > { > if (!net_dev->phydev) { > - netdev_dbg(net_dev, "phy device not initialized\n"); > return 0; > } ideally the now excess braces would be removed too. > @@ -96,7 +95,6 @@ static int dpaa_set_link_ksettings(struct net_device *net_dev, > int err; > > if (!net_dev->phydev) { > - netdev_err(net_dev, "phy device not initialized\n"); > return -ENODEV; > } etc...
Powered by blists - more mailing lists