netdev - Re: [PATCH 1/3] ipw2x00: Remove redundant variable "rc"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191031204449.GC30739@netronome.com>
Date:   Thu, 31 Oct 2019 21:44:49 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     kvalo@...eaurora.org, stas.yakovlev@...il.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] ipw2x00: Remove redundant variable "rc"

On Thu, Oct 31, 2019 at 09:46:18PM +0800, zhong jiang wrote:
> local variable "rc" is not used. hence it is safe to remove and
> just return 0.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

It appears that there is only one caller of
libipw_qos_convert_ac_to_parameters() and that it ignores the return value
(which, as you point out is always 0). 

Perhaps it would be cleaner if the return type of
libipw_qos_convert_ac_to_parameters() was void.

> ---
>  drivers/net/wireless/intel/ipw2x00/libipw_rx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/intel/ipw2x00/libipw_rx.c b/drivers/net/wireless/intel/ipw2x00/libipw_rx.c
> index 34cfd81..df0f37e4 100644
> --- a/drivers/net/wireless/intel/ipw2x00/libipw_rx.c
> +++ b/drivers/net/wireless/intel/ipw2x00/libipw_rx.c
> @@ -1005,7 +1005,6 @@ static int libipw_qos_convert_ac_to_parameters(struct
>  						  libipw_qos_parameters
>  						  *qos_param)
>  {
> -	int rc = 0;
>  	int i;
>  	struct libipw_qos_ac_parameter *ac_params;
>  	u32 txop;
> @@ -1030,7 +1029,8 @@ static int libipw_qos_convert_ac_to_parameters(struct
>  		txop = le16_to_cpu(ac_params->tx_op_limit) * 32;
>  		qos_param->tx_op_limit[i] = cpu_to_le16(txop);
>  	}
> -	return rc;
> +
> +	return 0;
>  }
>  
>  /*
> -- 
> 1.7.12.4
>