netdev - Re: [PATCH net v2] gve: Fixes DMA synchronization.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191031.141609.111804442534478009.davem@davemloft.net>
Date:   Thu, 31 Oct 2019 14:16:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yangchun@...gle.com
Cc:     netdev@...r.kernel.org, simon.horman@...ronome.com,
        csully@...gle.com
Subject: Re: [PATCH net v2] gve: Fixes DMA synchronization.

From: Yangchun Fu <yangchun@...gle.com>
Date: Wed, 30 Oct 2019 15:00:32 -0700

> -static int gve_tx_add_skb(struct gve_tx_ring *tx, struct sk_buff *skb)
> +static void gve_dma_sync_for_device(struct device *dev, dma_addr_t *page_buses,
> +				    u64 iov_offset, u64 iov_len)
> +{
> +	u64 addr;
> +	dma_addr_t dma;

Please place local variables in reverse christmas tree ordering (longest to
shortest line) here.

Thank you.