netdev - Re: [PATCH net v2] gve: Fixes DMA synchronization.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOPXMbmPbJxk1K7wwfVQNA1q5s8Kr1TB2Qk1oPSUsE6EsAWM_A@mail.gmail.com>
Date:   Thu, 31 Oct 2019 14:58:27 -0700
From:   Yangchun Fu <yangchun@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Simon Horman <simon.horman@...ronome.com>,
        Catherine Sullivan <csully@...gle.com>
Subject: Re: [PATCH net v2] gve: Fixes DMA synchronization.

On Thu, Oct 31, 2019 at 2:16 PM David Miller <davem@...emloft.net> wrote:
>
> From: Yangchun Fu <yangchun@...gle.com>
> Date: Wed, 30 Oct 2019 15:00:32 -0700
>
> > -static int gve_tx_add_skb(struct gve_tx_ring *tx, struct sk_buff *skb)
> > +static void gve_dma_sync_for_device(struct device *dev, dma_addr_t *page_buses,
> > +                                 u64 iov_offset, u64 iov_len)
> > +{
> > +     u64 addr;
> > +     dma_addr_t dma;
>
> Please place local variables in reverse christmas tree ordering (longest to
> shortest line) here.
>
> Thank you.

Sure I will send the v3 patch with this.