netdev - Re: [PATCH net-next] net: icmp: use input address in traceroute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+HUmGiv4DTdt0uRXr7yMsF0RjyZQU7BfrATmj8JatBJ25Eg6A@mail.gmail.com>
Date:   Fri, 1 Nov 2019 10:09:47 -0700
From:   Francesco Ruggeri <fruggeri@...sta.com>
To:     David Ahern <dsahern@...il.com>
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: icmp: use input address in traceroute

On Thu, Oct 31, 2019 at 8:11 PM David Ahern <dsahern@...il.com> wrote:
>
> Change looks good to me, so for that
> Reviewed-by: David Ahern <dsahern@...il.com>
>
> In this case and your ipv6 patch you have a set of commands to show this
> problem and verify the fix. Please submit both in a test script under
> tools/testing/selftests/net/. Also, veth pairs is a better way to
> connect namespaces than macvlan on a dummy device. See any of the fib*
> tests in that directory. Those all serve as good templates for a
> traceroute test script.
>

Sure, will do.
Thanks,
Francesco