netdev - Re: [PATCH net 0/3] fix BPF offload related bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191101100359.712d663a@cakuba.netronome.com>
Date:   Fri, 1 Nov 2019 10:03:59 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     davem@...emloft.net, alexei.starovoitov@...il.com,
        bpf@...r.kernel.org, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net 0/3] fix BPF offload related bugs

On Fri, 1 Nov 2019 13:10:13 +0100, Daniel Borkmann wrote:
> On 11/1/19 4:06 AM, Jakub Kicinski wrote:
> > Hi!
> > 
> > test_offload.py catches some recently added bugs.
> > 
> > First of a bug in test_offload.py itself after recent changes
> > to netdevsim is fixed.
> > 
> > Second patch fixes a bug in cls_bpf, and last one addresses
> > a problem with the recently added XDP installation optimization.
> > 
> > Jakub Kicinski (3):
> >    selftests: bpf: Skip write only files in debugfs
> >    net: cls_bpf: fix NULL deref on offload filter removal
> >    net: fix installing orphaned programs
> > 
> >   net/core/dev.c                              | 3 ++-
> >   net/sched/cls_bpf.c                         | 8 ++++++--
> >   tools/testing/selftests/bpf/test_offload.py | 5 +++++
> >   3 files changed, 13 insertions(+), 3 deletions(-)  
> 
> Should this go via -bpf or -net? Either way is fine, but asking
> given it's BPF related fixes; planning to do a PR in the evening,
> set looks good to me in any case.

FWIW I'm fine either way, too. I made it net after Alexei wondered if 
we should apply the revert to net-next, but since you took the revert 
to bpf-next perhaps bpf makes sense.

To state the obvious the only thing that matters is for the revert to
be in net-next when these are merged into net-next (IOW bpf-next PR is
what matters most at this point ;)).