netdev - Re: [PATCH v5 net-next 05/12] dt-bindings: net: ti: add new cpsw switch driver bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b81b6502-0e2b-d786-ae71-b40b0a1fab79@ti.com>
Date:   Fri, 1 Nov 2019 22:40:59 +0200
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Florian Fainelli <f.fainelli@...il.com>, <netdev@...r.kernel.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        "David S . Miller" <davem@...emloft.net>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
        Jiri Pirko <jiri@...nulli.us>
CC:     Sekhar Nori <nsekhar@...com>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>,
        Murali Karicheri <m-karicheri2@...com>,
        Ivan Vecera <ivecera@...hat.com>,
        Rob Herring <robh+dt@...nel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 net-next 05/12] dt-bindings: net: ti: add new cpsw
 switch driver bindings



On 01/11/2019 19:36, Florian Fainelli wrote:
> On 11/1/19 10:25 AM, Grygorii Strashko wrote:
>> Hi Florian,
>>
>> On 25/10/2019 20:47, Florian Fainelli wrote:
>>> On 10/24/19 3:09 AM, Grygorii Strashko wrote:
>>>> Add bindings for the new TI CPSW switch driver. Comparing to the legacy
>>>> bindings (net/cpsw.txt):
>>>> - ports definition follows DSA bindings (net/dsa/dsa.txt) and ports
>>>> can be
>>>> marked as "disabled" if not physically wired.
>>>> - all deprecated properties dropped;
>>>> - all legacy propertiies dropped which represent constant HW
>>>> cpapbilities
>>>> (cpdma_channels, ale_entries, bd_ram_size, mac_control, slaves,
>>>> active_slave)
>>>> - TI CPTS DT properties are reused as is, but grouped in "cpts" sub-node
>>>> - TI Davinci MDIO DT bindings are reused as is, because Davinci MDIO is
>>>> reused.
>>>>
>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
>>>> ---
>>>
>>> [snip]
>>>> +- mdio : CPSW MDIO bus block description
>>>> +    - bus_freq : MDIO Bus frequency
>>>
>>> clock-frequency is a more typical property to describe the bus clock's
>>> frequency, that is what i2c and spi do.
>>
>> The MDIO is re-used here unchanged (including bindings).
>> i think, I could try to add standard optional property "bus-frequency"
>> to MDIO bindings
>> as separate series, and deprecate "bus_freq".
> 
> What is wrong with 'clock-frequency'?
> 
> Documentation/devicetree/bindings/i2c/i2c.txt:
> 
> - clock-frequency
>          frequency of bus clock in Hz.
> 
> Documentation/devicetree/bindings/net/brcm,unimac-mdio.txt:
> 
> - clock-frequency: the MDIO bus clock that must be output by the MDIO bus
>    hardware, if absent, the default hardware values are used
> 
> Maybe this is a bit of a misnomer as it is usually considered a
> replacement for the lack of a proper "clocks" property with a clock
> provider, but we can flip the coin around any way we want, it looks
> almost the same.
> 

I can do clock-frequency, but I like more bus-frequency (personally)
due to more understandable meaning, and because in "Devicetree Specification v0.2"
clock-frequency is defined as more related to clocks.

Any way I hope you agree that it should be part separate discussion?


-- 
Best regards,
grygorii