netdev - Re: [PATCH bpf-next] Revert "selftests: bpf: Don't try to read files without read permission"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQKZbgqs3DJOsV4dtOY-ZXG8oQ7kWmJrJ_dS842qDrwABw@mail.gmail.com>
Date:   Thu, 31 Oct 2019 17:56:46 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        OSS Drivers <oss-drivers@...ronome.com>,
        bpf <bpf@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH bpf-next] Revert "selftests: bpf: Don't try to read files
 without read permission"

On Thu, Oct 31, 2019 at 5:51 PM Jakub Kicinski
<jakub.kicinski@...ronome.com> wrote:
>
> This reverts commit 5bc60de50dfe ("selftests: bpf: Don't try to read
> files without read permission").
>
> Quoted commit does not work at all, and was never tested.
> Script requires root permissions (and tests for them)
> and os.access() will always return true for root.
>
> The correct fix is needed in the bpf tree, so let's just
> revert and save ourselves the merge conflict.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Acked-by: Alexei Starovoitov <ast@...nel.org>
Since original commit is broken may be apply directly to net-next ?
I'm fine whichever way.
I would wait for Jiri to reply first though.