netdev - Re: [PATCH net-next] net: mscc: ocelot: fix __ocelot_rmw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191106.153450.832167829030748216.davem@davemloft.net>
Date:   Wed, 06 Nov 2019 15:34:50 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     jakub.kicinski@...ronome.com, alexandre.belloni@...tlin.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: mscc: ocelot: fix __ocelot_rmw_ix
 prototype

From: Vladimir Oltean <olteanv@...il.com>
Date: Wed,  6 Nov 2019 00:01:40 +0200

> The "read-modify-write register index" function is declared with a
> confusing prototype: the "mask" and "reg" arguments are swapped.
> 
> Fortunately, this does not affect callers so far. Both arguments are
> u32, and the wrapper macros (ocelot_rmw_ix etc) have the arguments in
> the correct order (the one from ocelot_io.c).
> 
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

I ended up applying this to 'net' but will not queue it up for -stable.

Thank you.