netdev - Re: [PATCH v2 bpf-next 0/2] bpf: Add array support to btf_struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLv+QjNmaLhuesjbtDFGfEiqxjMJgRf1mH2OeSfwAvskw@mail.gmail.com>
Date:   Wed, 6 Nov 2019 15:37:49 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v2 bpf-next 0/2] bpf: Add array support to btf_struct_access

On Wed, Nov 6, 2019 at 3:12 PM Martin KaFai Lau <kafai@...com> wrote:
>
> This series adds array support to btf_struct_access().
> Please see individual patch for details.
>
> v2:
> - Fix a divide-by-zero when there is empty array in
>   a struct (e.g. "__u8 __cloned_offset[0];" in skbuff)
> - Add 'static' to a global var in prog_tests/kfree_skb.c

still something wrong:
sysctl net.core.bpf_jit_enable=0
 ./test_progs -n 11
libbpf: failed to guess program type based on ELF section name 'test1'
libbpf: supported section(type) names are: socket kprobe/ uprobe/
kretprobe/ uretprobe/ classifier action tracepoint/ tp/
raw_tracepoint/ raw_tp/ tp_btf/ xdp perf_event lwt_in lwt_out lwt_xmit
lwt_seg6local cgroup_skb/ingress cgroup_skb/t
test_kfree_skb:PASS:prog_load sched cls 0 nsec
test_kfree_skb:PASS:prog_load raw tp 0 nsec
test_kfree_skb:PASS:find_prog 0 nsec
test_kfree_skb:PASS:attach_raw_tp 0 nsec
test_kfree_skb:PASS:find_perf_buf_map 0 nsec
test_kfree_skb:PASS:perf_buf__new 0 nsec
test_kfree_skb:PASS:ipv6 5219 nsec
on_sample:PASS:check_size 0 nsec
on_sample:PASS:check_meta_ifindex 0 nsec
on_sample:FAIL:check_cb8_0 cb8_0 0 != 84
test_kfree_skb:PASS:perf_buffer__poll 5219 nsec
test_kfree_skb:FAIL:114
#11 kfree_skb:FAIL
Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILED

Though it passes when JITed.