netdev - Re: [PATCH V9 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b26d298-0223-c5cc-9dd6-c4005139e32a@redhat.com>
Date:   Thu, 7 Nov 2019 22:30:37 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Alex Williamson <alex.williamson@...hat.com>,
        Randy Dunlap <rdunlap@...radead.org>
Cc:     kvm@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org,
        intel-gvt-dev@...ts.freedesktop.org, kwankhede@...dia.com,
        mst@...hat.com, tiwei.bie@...el.com,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        cohuck@...hat.com, maxime.coquelin@...hat.com,
        cunming.liang@...el.com, zhihong.wang@...el.com,
        rob.miller@...adcom.com, xiao.w.wang@...el.com,
        haotian.wang@...ive.com, zhenyuw@...ux.intel.com,
        zhi.a.wang@...el.com, jani.nikula@...ux.intel.com,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        airlied@...ux.ie, daniel@...ll.ch, farman@...ux.ibm.com,
        pasic@...ux.ibm.com, sebott@...ux.ibm.com, oberpar@...ux.ibm.com,
        heiko.carstens@...ibm.com, gor@...ux.ibm.com,
        borntraeger@...ibm.com, akrowiak@...ux.ibm.com,
        freude@...ux.ibm.com, lingshan.zhu@...el.com, idos@...lanox.com,
        eperezma@...hat.com, lulu@...hat.com, parav@...lanox.com,
        christophe.de.dinechin@...il.com, kevin.tian@...el.com,
        stefanha@...hat.com
Subject: Re: [PATCH V9 6/6] docs: sample driver to demonstrate how to
 implement virtio-mdev framework


On 2019/11/7 上午6:58, Alex Williamson wrote:
> On Wed, 6 Nov 2019 14:50:30 -0800
> Randy Dunlap <rdunlap@...radead.org> wrote:
>
>> On 11/5/19 11:05 PM, Jason Wang wrote:
>>> diff --git a/samples/Kconfig b/samples/Kconfig
>>> index c8dacb4dda80..13a2443e18e0 100644
>>> --- a/samples/Kconfig
>>> +++ b/samples/Kconfig
>>> @@ -131,6 +131,16 @@ config SAMPLE_VFIO_MDEV_MDPY
>>>   	  mediated device.  It is a simple framebuffer and supports
>>>   	  the region display interface (VFIO_GFX_PLANE_TYPE_REGION).
>>>   
>>> +config SAMPLE_VIRTIO_MDEV_NET
>>> +	tristate "Build VIRTIO net example mediated device sample code -- loadable modules only"
>>> +	depends on VIRTIO_MDEV && VHOST_RING && m
>>> +	help
>>> +	  Build a networking sample device for use as a virtio
>>> +	  mediated device. The device coopreates with virtio-mdev bus
>> typo here:
>> 	                              cooperates
>>
> I can fix this on commit relative to V10 if there are no other issues
> raised:
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index 13a2443e18e0..b7116d97cbbe 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -136,7 +136,7 @@ config SAMPLE_VIRTIO_MDEV_NET
>          depends on VIRTIO_MDEV && VHOST_RING && m
>          help
>            Build a networking sample device for use as a virtio
> -         mediated device. The device coopreates with virtio-mdev bus
> +         mediated device. The device cooperates with virtio-mdev bus
>            driver to present an virtio ethernet driver for
>            kernel. It simply loopbacks all packets from its TX
>            virtqueue to its RX virtqueue.
>
> Thanks,
> Alex


Thanks, per Michael request, I would rename mvnet and include this fix 
in V11.


>