netdev - Re: [PATCH v1 3/4] ksz: Add Microchip KSZ8863 SMI-DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191107155603.GH7344@lunn.ch>
Date:   Thu, 7 Nov 2019 16:56:03 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc:     netdev@...r.kernel.org, Tristram.Ha@...rochip.com,
        UNGLinuxDriver@...rochip.com, kernel@...gutronix.de
Subject: Re: [PATCH v1 3/4] ksz: Add Microchip KSZ8863 SMI-DSA driver

> +static const u8 stp_multicast_addr[] = {
> +	0x01, 0x80, 0xC2, 0x00, 0x00, 0x00
> +};

This probably exists already. Please go looking in include/linux and
include/net.

> +static int ksz8863_mdio_read(void *ctx, const void *reg_buf, size_t reg_len,
> +			     void *val_buf, size_t val_len)
> +{
> +	struct ksz_device *dev = (struct ksz_device *)ctx;

ctx is a void *, so you don't need the cast.

> +	struct mdio_device *mdev = (struct mdio_device *)dev->priv;

and priv is also probably a void *.

And please fix the reverse christmas tree.

Thanks
	Andrew