netdev - Re: [PATCH v1 3/4] ksz: Add Microchip KSZ8863 SMI-DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 9 Nov 2019 16:08:58 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        Tristram.Ha@...rochip.com, UNGLinuxDriver@...rochip.com,
        kernel@...gutronix.de
Subject: Re: [PATCH v1 3/4] ksz: Add Microchip KSZ8863 SMI-DSA driver

Hi Michael,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Michael-Grzeschik/microchip-add-support-for-ksz88x3-driver-family/20191109-122140
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git a2582cdc32f071422e0197a6c59bd1235b426ce2
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-21-gb31adac-dirty
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:184:17: sparse: sparse: cast to restricted __be64
>> drivers/net/dsa/microchip/ksz8863.c:193:14: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned long long [usertype] data @@    got nsigned long long [usertype] data @@
>> drivers/net/dsa/microchip/ksz8863.c:193:14: sparse:    expected unsigned long long [usertype] data
>> drivers/net/dsa/microchip/ksz8863.c:193:14: sparse:    got restricted __be64 [usertype]
   drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
   drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
   drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
   drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
   drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
   drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
   drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
   drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
   drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64
   drivers/net/dsa/microchip/ksz8863.c:252:23: sparse: sparse: cast to restricted __be64

vim +184 drivers/net/dsa/microchip/ksz8863.c

   172	
   173	static void ksz8863_r_table(struct ksz_device *dev, int table, u16 addr,
   174				    u64 *data)
   175	{
   176		u16 ctrl_addr;
   177	
   178		ctrl_addr = IND_ACC_TABLE(table | TABLE_READ) | addr;
   179	
   180		mutex_lock(&dev->alu_mutex);
   181		ksz_write16(dev, REG_IND_CTRL_0, ctrl_addr);
   182		ksz_read64(dev, REG_IND_DATA_HI, data);
   183		mutex_unlock(&dev->alu_mutex);
 > 184		*data = be64_to_cpu(*data);
   185	}
   186	
   187	static void ksz8863_w_table(struct ksz_device *dev, int table, u16 addr,
   188				    u64 data)
   189	{
   190		u16 ctrl_addr;
   191	
   192		ctrl_addr = IND_ACC_TABLE(table) | addr;
 > 193		data = cpu_to_be64(data);
   194	
   195		mutex_lock(&dev->alu_mutex);
   196		ksz_write64(dev, REG_IND_DATA_HI, data);
   197		ksz_write16(dev, REG_IND_CTRL_0, ctrl_addr);
   198		mutex_unlock(&dev->alu_mutex);
   199	}
   200	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation