netdev - Re: [PATCH net] net: ethernet: mediatek: rework GDM setup flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1573200809.10348.9.camel@mtksdccf07>
Date:   Fri, 8 Nov 2019 16:13:29 +0800
From:   mtk15127 <Mark-MC.Lee@...iatek.com>
To:     David Miller <davem@...emloft.net>
CC:     <sean.wang@...iatek.com>, <john@...ozen.org>,
        <matthias.bgg@...il.com>, <andrew@...n.ch>, <robh+dt@...nel.org>,
        <mark.rutland@....com>, <opensource@...rst.com>,
        <devicetree@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <jakub.kicinski@...ronome.com>,
        <Mark-MC.Lee@...iatek.com>
Subject: Re: [PATCH net] net: ethernet: mediatek: rework GDM setup flow

On Thu, 2019-11-07 at 15:49 -0800, David Miller wrote:
> From: MarkLee <Mark-MC.Lee@...iatek.com>
> Date: Thu, 7 Nov 2019 18:51:35 +0800
> 
> > +	for (i = 0; i < 2; i++) {
> 
> This is a regression, because in the existing code...
> 
> > -	for (i = 0; i < MTK_MAC_COUNT; i++) {
> 
> the proper macro is used instead of a magic constant.
 Yes, you are right, I make a mistake here, will correct it in the next
patch
> 
> You're doing so many things in one change, it's hard to review
> and audit.
> 
> If you're going to consolidate code, do that only in one change.
> 
> Then make other functional changes such as putting the chip into
> GDMA_DROP_ALL mode during the stop operation etc.
Thanks for your suggestion, I will separate these changes into
a patch series to make every change to be more clear for its 
purpose.