netdev - Re: [PATCH net-next] packet: fix data-race in fanout_flow_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191108.140645.867365524804910483.davem@davemloft.net>
Date:   Fri, 08 Nov 2019 14:06:45 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, willemb@...gle.com
Subject: Re: [PATCH net-next] packet: fix data-race in fanout_flow_is_huge()

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri,  8 Nov 2019 05:07:46 -0800

> KCSAN reported the following data-race [1]
> 
> Adding a couple of READ_ONCE()/WRITE_ONCE() should silence it.
> 
> Since the report hinted about multiple cpus using the history
> concurrently, I added a test avoiding writing on it if the
> victim slot already contains the desired value.
> 
> [1]
> 
> BUG: KCSAN: data-race in fanout_demux_rollover / fanout_demux_rollover
 ...
> Fixes: 3b3a5b0aab5b ("packet: rollover huge flows before small flows")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.