netdev - Re: [PATCH net 1/1] qede: fix NULL pointer deref in __qede

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191108.140841.647087207980890676.davem@davemloft.net>
Date:   Fri, 08 Nov 2019 14:08:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     manishc@...vell.com
Cc:     netdev@...r.kernel.org, aelior@...vell.com, skalluru@...vell.com
Subject: Re: [PATCH net 1/1] qede: fix NULL pointer deref in __qede_remove()

From: Manish Chopra <manishc@...vell.com>
Date: Fri, 8 Nov 2019 02:42:30 -0800

> While rebooting the system with SR-IOV vfs enabled leads
> to below crash due to recurrence of __qede_remove() on the VF
> devices (first from .shutdown() flow of the VF itself and
> another from PF's .shutdown() flow executing pci_disable_sriov())
> 
> This patch adds a safeguard in __qede_remove() flow to fix this,
> so that driver doesn't attempt to remove "already removed" devices.
 ...
> Signed-off-by: Manish Chopra <manishc@...vell.com>
> Signed-off-by: Ariel Elior <aelior@...vell.com>
> Signed-off-by: Sudarsana Kalluru <skalluru@...vell.com>

There should probably be a cleaner, more structural, way to prevent
this sequence.

But for now this fix is good enough.

Applied and queued up for -stable.