netdev - Re: [PATCH net-next 00/15] Accomodate DSA front-end into Ocelot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191110171611.GI25889@lunn.ch>
Date:   Sun, 10 Nov 2019 18:16:11 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     jakub.kicinski@...ronome.com, davem@...emloft.net,
        alexandre.belloni@...tlin.com, f.fainelli@...il.com,
        vivien.didelot@...il.com, joergen.andreasen@...rochip.com,
        allan.nielsen@...rochip.com, horatiu.vultur@...rochip.com,
        claudiu.manoil@....com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 00/15] Accomodate DSA front-end into Ocelot

On Sat, Nov 09, 2019 at 03:02:46PM +0200, Vladimir Oltean wrote:
> After the nice "change-my-mind" discussion about Ocelot, Felix and
> LS1028A (which can be read here: https://lkml.org/lkml/2019/6/21/630),
> we have decided to take the route of reworking the Ocelot implementation
> in a way that is DSA-compatible.
> 
> This is a large series, but hopefully is easy enough to digest, since it
> contains mostly code refactoring.

I just skimmed over the patches. Apart from the naming confusion at
the end, it all looks O.K.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

> It also means that Ocelot practically re-implements large parts of
> DSA (although it is not a DSA switch per se)

Would it make sense to refactor parts of the DSA core and export them
as helper function?

   Andrew