netdev - Re: [PATCH net-next 00/15] Accomodate DSA front-end into Ocelot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hoLu-Q38D9RSNV4be=Za3TSnWdpgY4d4Zczt=pNXC2QEA@mail.gmail.com>
Date:   Sun, 10 Nov 2019 19:22:02 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Joergen Andreasen <joergen.andreasen@...rochip.com>,
        "Allan W. Nielsen" <allan.nielsen@...rochip.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 00/15] Accomodate DSA front-end into Ocelot

On Sun, 10 Nov 2019 at 19:16, Andrew Lunn <andrew@...n.ch> wrote:
>
> On Sat, Nov 09, 2019 at 03:02:46PM +0200, Vladimir Oltean wrote:
> > After the nice "change-my-mind" discussion about Ocelot, Felix and
> > LS1028A (which can be read here: https://lkml.org/lkml/2019/6/21/630),
> > we have decided to take the route of reworking the Ocelot implementation
> > in a way that is DSA-compatible.
> >
> > This is a large series, but hopefully is easy enough to digest, since it
> > contains mostly code refactoring.
>
> I just skimmed over the patches. Apart from the naming confusion at
> the end, it all looks O.K.
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
>

Thanks a lot! Would it be too early if I also posted the Felix DSA
driver as well?

> > It also means that Ocelot practically re-implements large parts of
> > DSA (although it is not a DSA switch per se)
>
> Would it make sense to refactor parts of the DSA core and export them
> as helper function?

Where it helps, I'll sure consider doing that. We'll anyway need to
add support for tc-flower in DSA, filter blocks and all of that. At
the moment, only the FDB dump code was slightly duplicated, but then
again, that's because some boilerplate is needed, and it was there
anyway. So far it's manageable.

>
>    Andrew