netdev - Re: [PATCH net-next 10/12] net: dsa: vitesse: move vsc73xx driver to a separate folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191112145732.o7pkbitrvrr2bb7j@lx-anielsen.microsemi.net>
Date:   Tue, 12 Nov 2019 15:57:32 +0100
From:   "Allan W. Nielsen" <allan.nielsen@...rochip.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Vladimir Oltean <olteanv@...il.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Joergen Andreasen <joergen.andreasen@...rochip.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        netdev <netdev@...r.kernel.org>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 10/12] net: dsa: vitesse: move vsc73xx driver to
 a separate folder

The 11/12/2019 15:50, Andrew Lunn wrote:
> External E-Mail
> 
> 
> > > > As there are no commonalities between the vsc73xx and felix drivers,
> > > > shouldn't you simply leave that one out and have felix in the existing
> > > > microchip folder?
> > > >
> > > 
> > > I don't have a strong preference, although where I come from, all new
> > > NXP networking drivers are still labeled as "freescale" even though
> > > there is no code reuse. There are even less commonalities with
> > > Microchip (ex-Micrel, if I am not mistaken) KSZ switches than with the
> > > old vsc73xx. I'll let the ex-Vitesse people decide.
> > I'm on the same page as Alexandre here.
> 
> Leaving them where they are makes maintenance easier. Fixes are easier
> to backport if things don't move around.
> 
> > I think we should leave vsc73xx where it is already, and put the felix driver in
> > the drivers/net/ethernet/mscc/ folder where ocelot is already.
> 
> Currently, all DSA drivers are in drivers/net/dsa. We do occasionally
> make changes over all DSA drivers at once, so it is nice they are all
> together. So i would prefer the DSA part of Felix is also there. But
> the core can be in drivers/net/ethernet/mscc/.
Ahh, my bad.

In that case I do not have any strong feelings on this either.

I should say that we are discussing to add support for a Ocelot VSC7511 as a DSA
driver. This one does not have an internal MIPS CPU.

The vsc73xx, felix and the drivers in dsa/microchip does not share any
functionallity. Not in SW and not in HW.

Maybe felix should just go directly into drivers/net/dsa/, and then if we add
support for VSC7511 then they can both live in drivers/net/dsa/ocelot/

/Allan