netdev - Re: [PATCH v2 net-next] sfc: trace_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29aea663-e252-4c4f-1d29-d575395206ea@solarflare.com>
Date:   Tue, 12 Nov 2019 16:42:33 +0000
From:   Edward Cree <ecree@...arflare.com>
To:     Arthur Fabre <afabre@...udflare.com>,
        Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
        Charles McLachlan <cmclachlan@...arflare.com>,
        Martin Habets <mhabets@...arflare.com>,
        "David Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        <netdev@...r.kernel.org>, <bpf@...r.kernel.org>
CC:     <kernel-team@...udflare.com>
Subject: Re: [PATCH v2 net-next] sfc: trace_xdp_exception on XDP failure

On 12/11/2019 15:36, Arthur Fabre wrote:
> The sfc driver can drop packets processed with XDP, notably when running
> out of buffer space on XDP_TX, or returning an unknown XDP action.
> This increments the rx_xdp_bad_drops ethtool counter.
>
> Call trace_xdp_exception everywhere rx_xdp_bad_drops is incremented,
> except for fragmented RX packets as the XDP program hasn't run yet.
> This allows it to easily be monitored from userspace.
>
> This mirrors the behavior of other drivers.
>
> Signed-off-by: Arthur Fabre <afabre@...udflare.com>
Acked-by: Edward Cree <ecree@...arflare.com>