netdev - Re: [PATCH v2 net-next] sfc: trace_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191112.122410.512273112809490584.davem@davemloft.net>
Date:   Tue, 12 Nov 2019 12:24:10 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     afabre@...udflare.com
Cc:     linux-net-drivers@...arflare.com, ecree@...arflare.com,
        cmclachlan@...arflare.com, mhabets@...arflare.com, ast@...nel.org,
        daniel@...earbox.net, jakub.kicinski@...ronome.com,
        hawk@...nel.org, john.fastabend@...il.com, netdev@...r.kernel.org,
        bpf@...r.kernel.org, kernel-team@...udflare.com
Subject: Re: [PATCH v2 net-next] sfc: trace_xdp_exception on XDP failure

From: Arthur Fabre <afabre@...udflare.com>
Date: Tue, 12 Nov 2019 15:36:01 +0000

> The sfc driver can drop packets processed with XDP, notably when running
> out of buffer space on XDP_TX, or returning an unknown XDP action.
> This increments the rx_xdp_bad_drops ethtool counter.
> 
> Call trace_xdp_exception everywhere rx_xdp_bad_drops is incremented,
> except for fragmented RX packets as the XDP program hasn't run yet.
> This allows it to easily be monitored from userspace.
> 
> This mirrors the behavior of other drivers.
> 
> Signed-off-by: Arthur Fabre <afabre@...udflare.com>

Applied.