netdev - Re: [PATCH v1 net-next] mscc.c: Add support for additional VSC PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191112.122544.356627523822808563.davem@davemloft.net>
Date:   Tue, 12 Nov 2019 12:25:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Bryan.Whitehead@...rochip.com
Cc:     netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v1 net-next] mscc.c: Add support for additional VSC PHYs

From: Bryan Whitehead <Bryan.Whitehead@...rochip.com>
Date: Tue, 12 Nov 2019 10:54:08 -0500

>  		phy = container_of(map[addr], struct phy_device, mdio);

Unnecessary space added between this assignment and the test.

> +		if (!phy)
> +			continue;

And this test makes no sense, the result of container_of() is never NULL
unless it is for the first member of a structure of a NULL pointer.