netdev - Re: [PATCH net-next 0/3] r8169: use rtl821x_modify_extpage exported from Realtek PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191112.200830.1524247803414226770.davem@davemloft.net>
Date:   Tue, 12 Nov 2019 20:08:30 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, nic_swsd@...ltek.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/3] r8169: use rtl821x_modify_extpage
 exported from Realtek PHY driver

From: David Miller <davem@...emloft.net>
Date: Tue, 12 Nov 2019 19:56:03 -0800 (PST)

> From: Heiner Kallweit <hkallweit1@...il.com>
> Date: Tue, 12 Nov 2019 22:22:55 +0100
> 
>> Certain Realtek PHY's support a proprietary "extended page" access mode
>> that is used in the Realtek PHY driver and in r8169 network driver.
>> Let's implement it properly in the Realtek PHY driver and export it for
>> use in other drivers like r8169.
> 
> Applied, but I really wish these deps worked more nicely.
> 
> Now I have to know what PHY drivers my ethernet card uses just to have
> the main driver show up as a possible option in the Kconfig.  That's
> not nice at all.

I had to revert, missing types.h include in the new header file or similar:

./include/linux/realtek_phy.h:6:16: error: unknown type name ‘u16’
       int reg, u16 mask, u16 val);
                ^~~
./include/linux/realtek_phy.h:6:26: error: unknown type name ‘u16’
       int reg, u16 mask, u16 val);
                          ^~~