netdev - Re: [PATCH net-next 0/3] r8169: use rtl821x_modify_extpage exported from Realtek PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Nov 2019 20:13:24 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/3] r8169: use rtl821x_modify_extpage exported
 from Realtek PHY driver



On 11/12/2019 1:22 PM, Heiner Kallweit wrote:
> Certain Realtek PHY's support a proprietary "extended page" access mode
> that is used in the Realtek PHY driver and in r8169 network driver.
> Let's implement it properly in the Realtek PHY driver and export it for
> use in other drivers like r8169.
> 
> Heiner Kallweit (3):
>   net: phy: realtek: export rtl821x_modify_extpage
>   r8169: use rtl821x_modify_extpage
>   r8169: consider new hard dependency on REALTEK_PHY
> 
>  drivers/net/ethernet/realtek/Kconfig      |  3 +-
>  drivers/net/ethernet/realtek/r8169_main.c | 41 +++++++++--------------
>  drivers/net/phy/realtek.c                 | 36 ++++++++++++--------
>  include/linux/realtek_phy.h               |  8 +++++
>  4 files changed, 46 insertions(+), 42 deletions(-)

The delta is not that impressive and this creates not quite a layering
violation, but some really weird inter dependency if nothing else. Could
we simply move all the PHY programming down the PHY driver instead or is
this too cumbersome/fragile to do right now?
-- 
Florian