netdev - Re: [PATCH net-next 1/2] cxgb4: add TC-MATCHALL classifier egress offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191114132041.GA12021@chelsio.com>
Date:   Thu, 14 Nov 2019 18:50:43 +0530
From:   Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nirranjan@...lsio.com,
        vishal@...lsio.com, dt@...lsio.com
Subject: Re: [PATCH net-next 1/2] cxgb4: add TC-MATCHALL classifier egress
 offload

On Wednesday, November 11/13/19, 2019 at 19:14:02 -0800, Jakub Kicinski wrote:
> On Wed, 13 Nov 2019 20:09:20 +0530, Rahul Lakkireddy wrote:
> > Add TC-MATCHALL classifier offload with TC-POLICE action applied for all
> > outgoing traffic on the underlying interface. Split flow block offload
> > to support both egress and ingress classification.
> > 
> > For example, to rate limit all outgoing traffic to 1 Gbps:
> > 
> > $ tc qdisc add dev enp2s0f4 clsact
> > $ tc filter add dev enp2s0f4 egress matchall skip_sw \
> > 	action police rate 1Gbit burst 8Kbit
> > 
> > Note that skip_sw is important. Otherwise, both stack and hardware
> > will end up doing policing. 
> 
> You also can't offload policers from shared blocks (well, shared
> actions in general, but let's say checking shared blocks is enough).
> 

Ok. Will add a check in v2 to reject police action offload for shared
blocks.

> > Only 1 egress matchall rule can be active
> > at a time on the underlying interface.
> > 
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>

Thanks,
Rahul