netdev - Re: [PATCH net-next 2/2] cxgb4: add TC-MATCHALL classifier ingress offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191114132143.GB12021@chelsio.com>
Date:   Thu, 14 Nov 2019 18:51:44 +0530
From:   Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nirranjan@...lsio.com,
        vishal@...lsio.com, dt@...lsio.com
Subject: Re: [PATCH net-next 2/2] cxgb4: add TC-MATCHALL classifier ingress
 offload

On Wednesday, November 11/13/19, 2019 at 19:16:10 -0800, Jakub Kicinski wrote:
> On Wed, 13 Nov 2019 20:09:21 +0530, Rahul Lakkireddy wrote:
> > +static int cxgb4_matchall_alloc_filter(struct net_device *dev,
> > +				       struct tc_cls_matchall_offload *cls)
> > +{
> > +	struct cxgb4_tc_port_matchall *tc_port_matchall;
> > +	struct port_info *pi = netdev2pinfo(dev);
> > +	struct adapter *adap = netdev2adap(dev);
> > +	struct ch_filter_specification *fs;
> > +	int ret, fidx;
> > +
> > +	/* Since the rules with lower indices have higher priority, place
> > +	 * MATCHALL rule at the highest free index of the TCAM because
> > +	 * MATCHALL is usually not a high priority filter and is generally
> > +	 * used as a last rule, if all other rules fail.
> > +	 */
> 
> The rule ordering in HW must match the ordering in the kernel.
> 

Ok. Will maintain the same ordering as in kernel in v2.

> > +	fidx = cxgb4_get_last_free_ftid(dev);
> > +	if (fidx < 0)
> > +		return -ENOMEM;
> 

Thanks,
Rahul