[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20191114.151130.1285429961478372878.davem@davemloft.net>
Date: Thu, 14 Nov 2019 15:11:30 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: olteanv@...il.com
Cc: andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: sja1105: Simplify reset handling
From: Vladimir Oltean <olteanv@...il.com>
Date: Wed, 13 Nov 2019 00:16:41 +0200
> We don't really need 10k species of reset. Remove everything except cold
> reset which is what is actually used. Too bad the hardware designers
> couldn't agree to use the same bit field for rev 1 and rev 2, so the
> (*reset_cmd) function pointer is there to stay.
>
> However let's simplify the prototype and give it a struct dsa_switch (we
> want to avoid forward-declarations of structures, in this case struct
> sja1105_private, wherever we can).
>
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>
Applied, thank you.
Powered by blists - more mailing lists