netdev - Re: [net-next 1/1] netfilter: nf_tables_offload: Fix dangling extack pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191114231334.kyynwmyyxysthzci@salvia>
Date:   Fri, 15 Nov 2019 00:13:34 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net-next 1/1] netfilter: nf_tables_offload: Fix dangling extack
 pointer

Hi Saeed,

Thanks for your patch.

On Thu, Nov 14, 2019 at 10:02:00PM +0000, Saeed Mahameed wrote:
> nft_flow_cls_offload_setup() will setup cls_flow->common->extack to point
> to a local extack object on its stack, this extack pointer is meant to
> be used on nft_setup_cb_call() driver's callbacks, which is called after
> nft_flow_cls_offload_setup() is terminated and thus will lead to a
> dangling pointer.

There's a fix for this in nf-next:

https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/?id=be193f5e21d0ec674badef9fde8eca71fb2d8546

Will send a pull request asap.