netdev - Re: [PATCH net] mlxsw: spectrum_router: Fix determining underlay for a GRE tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191118.171036.1233493018225366675.davem@davemloft.net>
Date:   Mon, 18 Nov 2019 17:10:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, petrm@...lanox.com,
        mlxsw@...lanox.com, idosch@...lanox.com
Subject: Re: [PATCH net] mlxsw: spectrum_router: Fix determining underlay
 for a GRE tunnel

From: Ido Schimmel <idosch@...sch.org>
Date: Mon, 18 Nov 2019 09:18:42 +0200

> From: Petr Machata <petrm@...lanox.com>
> 
> The helper mlxsw_sp_ipip_dev_ul_tb_id() determines the underlay VRF of a
> GRE tunnel. For a tunnel without a bound device, it uses the same VRF that
> the tunnel is in. However in Linux, a GRE tunnel without a bound device
> uses the main VRF as the underlay. Fix the function accordingly.
> 
> mlxsw further assumed that moving a tunnel to a different VRF could cause
> conflict in local tunnel endpoint address, which cannot be offloaded.
> However, the only way that an underlay could be changed by moving the
> tunnel device itself is if the tunnel device does not have a bound device.
> But in that case the underlay is always the main VRF, so there is no
> opportunity to introduce a conflict by moving such device. Thus this check
> constitutes a dead code, and can be removed, which do.
> 
> Fixes: 6ddb7426a7d4 ("mlxsw: spectrum_router: Introduce loopback RIFs")
> Signed-off-by: Petr Machata <petrm@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied and queued up for -stable.