netdev - Re: [PATCH net-next 0/5] selftests: Add ethtool and scale tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191118.171214.1598210978663189090.davem@davemloft.net>
Date:   Mon, 18 Nov 2019 17:12:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com,
        mlxsw@...lanox.com, idosch@...lanox.com
Subject: Re: [PATCH net-next 0/5] selftests: Add ethtool and scale tests

From: Ido Schimmel <idosch@...sch.org>
Date: Mon, 18 Nov 2019 09:49:57 +0200

> From: Ido Schimmel <idosch@...lanox.com>
> 
> This patch set adds generic ethtool tests and a mlxsw-specific router
> scale test for Spectrum-2.
> 
> Patches #1-#2 from Danielle add the router scale test for Spectrum-2. It
> re-uses the same test as Spectrum-1, but it is invoked with a different
> scale, according to what it is queried from devlink-resource.
> 
> Patches #3-#5 from Amit are a re-work of the ethtool tests that were
> posted in the past [1]. Patches #3-#4 add the necessary library
> routines, whereas patch #5 adds the test itself. The test checks both
> good and bad flows with autoneg on and off. The test plan it detailed in
> the commit message.
> 
> Last time Andrew and Florian (copied) provided very useful feedback that
> is incorporated in this set. Namely:
> 
> * Parse the value of the different link modes from
>   /usr/include/linux/ethtool.h
> * Differentiate between supported and advertised speeds and use the
>   latter in autoneg tests
> * Make the test generic and move it to net/forwarding/ instead of being
>   mlxsw-specific
> 
> [1] https://patchwork.ozlabs.org/cover/1112903/

Series applied, thank you.