netdev - Re: [PATCH net 1/1] mdio_bus: fix mdio_register_device when RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Nov 2019 12:27:44 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Marek Behún <marek.behun@....cz>
Cc:     netdev@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net 1/1] mdio_bus: fix mdio_register_device when
 RESET_CONTROLLER is disabled

On Mon, Nov 18, 2019 at 07:15:05PM +0100, Marek Behún wrote:
> When CONFIG_RESET_CONTROLLER is disabled, the
> devm_reset_control_get_exclusive function returns -ENOTSUPP. This is not
> handled in subsequent check and then the mdio device fails to probe.
> 
> When CONFIG_RESET_CONTROLLER is enabled, its code checks in OF for reset
> device, and since it is not present, returns -ENOENT. -ENOENT is handled.
> Add -ENOTSUPP also.
> 
> This happened to me when upgrading kernel on Turris Omnia. You either
> have to enable CONFIG_RESET_CONTROLLER or use this patch.

In the long term prospective shouldn't it use
reset_control_get_optional_exclusive() instead?

-- 
With Best Regards,
Andy Shevchenko