netdev - Re: [PATCH net-next v3 1/2] ipv6: introduce and uses route look hints for list input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Nov 2019 09:40:21 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Edward Cree <ecree@...arflare.com>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next v3 1/2] ipv6: introduce and uses route look hints
 for list input



On 11/19/19 9:34 AM, Eric Dumazet wrote:
> 

>>  
>> +static bool ip6_can_use_hint(struct sk_buff *skb, const struct sk_buff *hint)
>> +{
>> +	return hint && !skb_dst(skb) &&
>> +	       ipv6_addr_equal(&ipv6_hdr(hint)->daddr, &ipv6_hdr(skb)->daddr);
>> +}
>> +
> 
> Why keeping whole skb as the hint, since all you want is the ipv6_hdr(skb)->daddr ?
> 
> Remembering the pointer to daddr would avoid de-referencing many skb fields.
> 

Ah we also need the hint dst, scrap this then...