netdev - Re: [PATCH net-next v3 1/2] ipv6: introduce and uses route look hints for list input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <115be9f5-7c80-5df9-f030-ae62d83f0e8b@gmail.com>
Date:   Tue, 19 Nov 2019 10:40:51 -0700
From:   David Ahern <dsahern@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Edward Cree <ecree@...arflare.com>
Subject: Re: [PATCH net-next v3 1/2] ipv6: introduce and uses route look hints
 for list input

On 11/19/19 10:34 AM, Eric Dumazet wrote:
>> diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
>> index 5d1615463138..9ab60611b97b 100644
>> --- a/include/net/ip6_fib.h
>> +++ b/include/net/ip6_fib.h
>> @@ -502,6 +502,11 @@ static inline bool fib6_metric_locked(struct fib6_info *f6i, int metric)
>>  }
>>  
>>  #ifdef CONFIG_IPV6_MULTIPLE_TABLES
>> +static inline bool fib6_has_custom_rules(struct net *net)
> 
> const struct net *net
> 
>> +{
>> +	return net->ipv6.fib6_has_custom_rules;
> 
> It would be nice to be able to detect that some custom rules only impact egress routes :/
> 

Or vrf. :-)

It's a common problem that needs a better solution - not lumping the
full complexity of fib rules into a single boolean.