netdev - Re: [PATCH net-next v3 1/2] ipv6: introduce and uses route look hints for list input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53775b48bd52a148598ee418600c0b3cd01277c3.camel@redhat.com>
Date:   Tue, 19 Nov 2019 22:41:06 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Edward Cree <ecree@...arflare.com>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next v3 1/2] ipv6: introduce and uses route look
 hints for list input

On Tue, 2019-11-19 at 09:34 -0800, Eric Dumazet wrote:
> On 11/19/19 6:38 AM, Paolo Abeni wrote:
> > diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
> > index 5d1615463138..9ab60611b97b 100644
> > --- a/include/net/ip6_fib.h
> > +++ b/include/net/ip6_fib.h
> > @@ -502,6 +502,11 @@ static inline bool fib6_metric_locked(struct fib6_info *f6i, int metric)
> >  }
> >  
> >  #ifdef CONFIG_IPV6_MULTIPLE_TABLES
> > +static inline bool fib6_has_custom_rules(struct net *net)
> 
> const struct net *net

Yep, will do in the next iteration.

> > +{
> > +	return net->ipv6.fib6_has_custom_rules;
> 
> It would be nice to be able to detect that some custom rules only impact egress routes :/

My [mis-] understanding is that addressing correctly the above (and VRF
and likely many other use-cases) is beyond these patches scope.

> > +}
> > +
> >  int fib6_rules_init(void);
> >  void fib6_rules_cleanup(void);
> >  bool fib6_rule_default(const struct fib_rule *rule);
> > @@ -527,6 +532,10 @@ static inline bool fib6_rules_early_flow_dissect(struct net *net,
> >  	return true;
> >  }
> >  #else
> > +static inline bool fib6_has_custom_rules(struct net *net)
> 
> const struct net *net

Ditto ;)

> > +{
> > +	return 0;
> 
> 	return false;
> 
> 
> BTW, this deserves a patch on its own :)

Oks, will do

> > +}
> >  static inline int               fib6_rules_init(void)
> >  {
> >  	return 0;
> > diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c
> > index ef7f707d9ae3..792b52aa9fc9 100644
> > --- a/net/ipv6/ip6_input.c
> > +++ b/net/ipv6/ip6_input.c
> > @@ -59,6 +59,7 @@ static void ip6_rcv_finish_core(struct net *net, struct sock *sk,
> >  			INDIRECT_CALL_2(edemux, tcp_v6_early_demux,
> >  					udp_v6_early_demux, skb);
> >  	}
> > +
> 
> Why adding a new line ? Please refrain adding noise to a patch.

Sorry this is a left-over from previous iterations, will fix in the
next one.

Thank you for the detailed feedback!

Paolo