netdev - Re: [PATCH 02/15] octeontx2-af: Add support for importing firmware data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191119133841.16f91648@cakuba.netronome.com>
Date:   Tue, 19 Nov 2019 13:38:41 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Sunil Kovvuri <sunil.kovvuri@...il.com>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Linu Cherian <lcherian@...vell.com>,
        Rakesh Babu <rsaladi2@...vell.com>,
        Vamsi Attunuru <vamsi.attunuru@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH 02/15] octeontx2-af: Add support for importing firmware
 data

On Tue, 19 Nov 2019 13:01:41 +0530, Sunil Kovvuri wrote:
> On Tue, Nov 19, 2019 at 2:58 AM Jakub Kicinskiwrote:
> > Again, confusing about what this code is actually doing. Looks like
> > it's responding to some mailbox requests..
> >
> > Please run checkpatch --strict and fix all the whitespace issues, incl.
> > missing spaces around comments and extra new lines.  
> 
> I did check that and didn't see any issues.
> 
> ./scripts/checkpatch.pl --patch --strict
> 0002-octeontx2-af-Add-support-for-importing-firmware-data.patch
> total: 0 errors, 0 warnings, 0 checks, 349 lines checked
> 
> 0002-octeontx2-af-Add-support-for-importing-firmware-data.patch has no
> obvious style problems and is ready for submission.

Oh well, checkpatch didn't catch any errors so you didn't care to look
for mistakes I pointed out yourself?

Let me ask you again, please fix all the whitespace issues incl.
missing spaces around comments and extra new lines.