netdev - Re: [PATCH 03/15] octeontx2-af: Cleanup CGX config permission checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+sq2Cd0uKo9P7d-Wos_oPQBshKkQ0Cyk1_C0sjKqNaMeBrOKA@mail.gmail.com>
Date:   Tue, 19 Nov 2019 13:03:50 +0530
From:   Sunil Kovvuri <sunil.kovvuri@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH 03/15] octeontx2-af: Cleanup CGX config permission checks

On Mon, Nov 18, 2019 at 12:03 AM David Miller <davem@...emloft.net> wrote:
>
> From: sunil.kovvuri@...il.com
> Date: Sun, 17 Nov 2019 21:44:14 +0530
>
> > From: Sunil Goutham <sgoutham@...vell.com>
> >
> > Most of the CGX register config is restricted to mapped RVU PFs,
> > this patch cleans up these permission checks spread across
> > the rvu_cgx.c file by moving the checks to a common fn().
> >
> > Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> > ---
> >  .../net/ethernet/marvell/octeontx2/af/rvu_cgx.c    | 55 ++++++++++------------
> >  1 file changed, 24 insertions(+), 31 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> > index 0bbb2eb..5790a76 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> > @@ -350,6 +350,18 @@ int rvu_cgx_exit(struct rvu *rvu)
> >       return 0;
> >  }
> >
> > +/* Most of the CGX configuration is restricted to the mapped PF only,
> > + * VF's of mapped PF and other PFs are not allowed. This fn() checks
> > + * whether a PFFUNC is permitted to do the config or not.
> > + */
> > +inline bool is_cgx_config_permitted(struct rvu *rvu, u16 pcifunc)
> > +{
> > +     if ((pcifunc & RVU_PFVF_FUNC_MASK) ||
> > +         !is_pf_cgxmapped(rvu, rvu_get_pf(pcifunc)))
> > +             return false;
> > +     return true;
> > +}
>
> Do not use inline in foo.c files, let the compiler decide.

Sorry for the trouble.. i did check and removed 'inline' from
different patches of this patchset.
Somehow missed this, will fix and resubmit,

Thanks,
Sunil.