netdev - Re: [PATCH v2 00/15] octeontx2-af: SSO, TIM HW blocks and other config support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191119134638.6814285a@cakuba.netronome.com>
Date:   Tue, 19 Nov 2019 13:46:38 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH v2 00/15] octeontx2-af: SSO, TIM HW blocks and other
 config support

On Tue, 19 Nov 2019 16:47:24 +0530, sunil.kovvuri@...il.com wrote:
> From: Sunil Goutham <sgoutham@...vell.com>
> 
> SSO HW block provides packet (or work) queueing, scheduling and
> synchronization. Also supports priorities and ordering. TIM or the
> timer HW block enables software to schedule SSO work for a future time.
> 
> This patch series adds support for SSO and TIM HW blocks, enables them
> to be configured and used by RVU PF/VF devices or drivers.
> 
> Also added support for
> - Backpressure configuration.
> - Pause frames or flow control enabling/disabling.
> - Added a shared data structure between firmware and RVU admin function
>   (AF) which will be used to get static information like interface MAC
>   addresses, link modes, speeds, autoneg support etc.
> - FEC (Forward error correction) config support for CGX.
> - Retrieve FEC stats, PHY EEPROM etc from firmware
> - Retrieving CGX LMAC info and to toggle it.
> - Added debug prints for each of error interrupts raised by NIX,
>   NPA and SSO blocks. These will help in identifying configuration
>   and underlying HW functionality issues.

Please CC people who gave you reviews on new version of the patches.
Especially if you didn't bother to address/answer it.

This driver doesn't seem to function in ways which are familiar in
the upstream Linux kernel.

As I asked in my review of patch 4 in v1, please provide us with
accurate description of how does a system with a octeontx2 operate.
Best in the form of RST documentation in the Documentation/ directory,
otherwise it's very hard for upstream folks to review what you're doing.

Thank you.