netdev - Re: [PATCH v2] net-af_xdp: use correct number of channels from ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191119140301.6ff669e1@cakuba.netronome.com>
Date:   Tue, 19 Nov 2019 14:03:01 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Luigi Rizzo <lrizzo@...gle.com>
Cc:     magnus.karlsson@...el.com, bjorn.topel@...el.com,
        jonathan.lemon@...il.com, netdev@...r.kernel.org,
        bpf@...r.kernel.org, rizzo@....unipi.it
Subject: Re: [PATCH v2] net-af_xdp: use correct number of channels from
 ethtool

On Mon, 18 Nov 2019 16:19:51 -0800, Luigi Rizzo wrote:
> Drivers use different fields to report the number of channels, so take
> the maximum of all data channels (rx, tx, combined) when determining the
> size of the xsk map. The current code used only 'combined' which was set
> to 0 in some drivers e.g. mlx4.
> 
> Tested: compiled and run xdpsock -q 3 -r -S on mlx4
> Signed-off-by: Luigi Rizzo <lrizzo@...gle.com>

Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>