netdev - Re: [PATCH net v3] net: fec: fix clock count mis-match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191119.145513.561465860770576481.davem@davemloft.net>
Date:   Tue, 19 Nov 2019 14:55:13 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hslester96@...il.com
Cc:     fugang.duan@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3] net: fec: fix clock count mis-match

From: Chuhong Yuan <hslester96@...il.com>
Date: Mon, 18 Nov 2019 20:18:26 +0800

> pm_runtime_put_autosuspend in probe will call suspend to disable clks
> automatically if CONFIG_PM is defined. (If CONFIG_PM is not defined,
> its implementation will be empty, then suspend will not be called.)
> 
> Therefore, we can call pm_runtime_get_sync to resume it first to enable
> clks, which matches the suspend. (Only when CONFIG_PM is defined, otherwise
> pm_runtime_get_sync will also be empty, then resume will not be called.)
> 
> Then it is fine to disable clks without causing clock count mis-match.
> 
> Fixes: c43eab3eddb4 ("net: fec: add missed clk_disable_unprepare in remove")
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

Please fix the commit message typos pointed out by Andy Duan and resubmit,
thank you.