netdev - RE: [PATCH] net/tls: enable sk_msg redirect to tls socket egress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dd38205959a5_613b2afc5fa285c4e6@john-XPS-13-9370.notmuch>
Date:   Mon, 18 Nov 2019 21:47:49 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        netdev@...r.kernel.org
Cc:     bpf@...r.kernel.org, john.fastabend@...il.com,
        jakub.kicinski@...ronome.com, daniel@...earbox.net,
        Willem de Bruijn <willemb@...gle.com>
Subject: RE: [PATCH] net/tls: enable sk_msg redirect to tls socket egress

Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> Bring back tls_sw_sendpage_locked. sk_msg redirection into a socket
> with TLS_TX takes the following path:
> 
>   tcp_bpf_sendmsg_redir
>     tcp_bpf_push_locked
>       tcp_bpf_push
>         kernel_sendpage_locked
>           sock->ops->sendpage_locked
> 
> Also update the flags test in tls_sw_sendpage_locked to allow flag
> MSG_NO_SHARED_FRAGS. bpf_tcp_sendmsg sets this.
> 
> Link: https://lore.kernel.org/netdev/CA+FuTSdaAawmZ2N8nfDDKu3XLpXBbMtcCT0q4FntDD2gn8ASUw@mail.gmail.com/T/#t
> Link: https://github.com/wdebruij/kerneltools/commits/icept.2
> Fixes: 0608c69c9a80 ("bpf: sk_msg, sock{map|hash} redirect through ULP")
> Fixes: f3de19af0f5b ("Revert \"net/tls: remove unused function tls_sw_sendpage_locked\"")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> ---

Acked-by: John Fastabend <john.fastabend@...il.com>